Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Azure doc link rendering #26763

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Conversation

C00ldudeNoonan
Copy link
Contributor

Summary & Motivation

The link for Azure Default Credentials and Secret Credentials in the AzureBlobComputeLogManager class was formatted as a markdown link instead of in rst format. This was causing the docs and docs beta build to fail. There was another minor issue in with sling_mac_arm64 not being added in the autodoc_mock_imports list.

How I Tested These Changes

image

@C00ldudeNoonan C00ldudeNoonan added the area: api-docs Related to the content of API docs label Dec 31, 2024
Copy link

github-actions bot commented Dec 31, 2024

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-60d0i12tt-elementl.vercel.app
https://noonan-azure-docs-link-update.dagster.dagster-docs.io

Direct link to changed pages:

Copy link

github-actions bot commented Dec 31, 2024

Deploy preview for dagster-docs-beta ready!

Preview available at https://dagster-docs-beta-rdamogivy-elementl.vercel.app

Direct link to changed pages:

@C00ldudeNoonan C00ldudeNoonan merged commit 32b7670 into master Dec 31, 2024
3 checks passed
@C00ldudeNoonan C00ldudeNoonan deleted the noonan/azure-docs-link-update branch December 31, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: api-docs Related to the content of API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants