Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New BFS method for use in asset backfills #26751

Merged
merged 3 commits into from
Dec 31, 2024
Merged

New BFS method for use in asset backfills #26751

merged 3 commits into from
Dec 31, 2024

Conversation

gibsondan
Copy link
Member

Summary:
Pulling out the new BFS utility added in #25997 to its own function with its own tests to keep the PR size manageable.

Test Plan: New tests

NOCHANGELOG

Summary & Motivation

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

Copy link
Contributor

@jamiedemaria jamiedemaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions about the partition sort key fn

Copy link
Contributor

@OwenKephart OwenKephart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be useful to add a test that makes sure things don't get weird with self-dependent assets -- just by inspection I have no reason to believe it wouldn't work properly, but always nice to test the "hard" cases

@gibsondan
Copy link
Member Author

  • added a self dependant asset test case

Summary:
Pulling out the new BFS utility added in #25997 to its own function with its own tests to keep the PR size manageable.

Test Plan: New tests

NOCHANGELOG
> Insert changelog entry or delete this section.
> Insert changelog entry or delete this section.
@gibsondan gibsondan merged commit d54f10c into master Dec 31, 2024
1 check was pending
@gibsondan gibsondan deleted the bfsreal0 branch December 31, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants