Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dagster-ssh] Update to Pythonic resources #15180

Merged
merged 5 commits into from
Nov 10, 2023
Merged

[dagster-ssh] Update to Pythonic resources #15180

merged 5 commits into from
Nov 10, 2023

Conversation

benpankow
Copy link
Member

@benpankow benpankow commented Jul 7, 2023 •
edited
Loading

Summary

Updates the SSHResource to be a ConfigurableResource.

Resolves #15108.

Test Plan

Existing unit tests. New unit test param which uses the Pythonic resource.

@benpankow
Copy link
Member Author

benpankow commented Jul 7, 2023 •
edited by jamiedemaria
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@benpankow benpankow force-pushed the benpankow/update-dagster-ssh branch from f29ff8c to 7051ff8 Compare July 7, 2023 23:18
@benpankow benpankow marked this pull request as ready for review July 7, 2023 23:19
jamiedemaria
jamiedemaria reviewed Jul 11, 2023
View reviewed changes
Copy link
Contributor

@jamiedemaria jamiedemaria left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple small qs, but looks good! TY for doing this so quickly!

python_modules/libraries/dagster-ssh/dagster_ssh/resources.py Outdated Show resolved Hide resolved
python_modules/libraries/dagster-ssh/dagster_ssh/resources.py Show resolved Hide resolved
python_modules/libraries/dagster-ssh/dagster_ssh/resources.py
args = init_context.resource_config
args = merge_dicts(init_context.resource_config, {"logger": init_context.log})
return SSHResource(**args)
return SSHResource.from_resource_context(init_context)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the config for the function resource different from the ConfigurableResource so we cant do SSHResource.to_config_schema()

@jamiedemaria
Copy link
Contributor

bump on this PR!

jamiedemaria
jamiedemaria reviewed Aug 11, 2023
View reviewed changes
Copy link
Contributor

@jamiedemaria jamiedemaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before merge, the SSHResource should be added to the API docs. And a PR into dagster-website to update the integration code snippet would be great!

@caleboverman
Copy link

@jamiedemaria @benpankow anything I can do to help get this finished? We're hoping to use the new pythonic resource soon

@DanteOz DanteOz mentioned this pull request Oct 30, 2023
Closed
@jamiedemaria jamiedemaria force-pushed the benpankow/update-dagster-ssh branch from 7051ff8 to 54ed8ae Compare November 10, 2023 21:07
@github-actions GitHub Actions
Copy link

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-ac7jeiijb-elementl.vercel.app
https://benpankow-update-dagster-ssh.core-storybook.dagster-docs.io

Built with commit 54ed8ae.
This pull request is being automatically deployed with vercel-action

@github-actions GitHub Actions
Copy link

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-gllyqkvuz-elementl.vercel.app
https://benpankow-update-dagster-ssh.components-storybook.dagster-docs.io

Built with commit 54ed8ae.
This pull request is being automatically deployed with vercel-action

@github-actions GitHub Actions
Copy link

Deploy preview for dagster-university ready!

✅ Preview
https://dagster-university-o5a6cldkd-elementl.vercel.app
https://benpankow-update-dagster-ssh.dagster-university.dagster-docs.io

Built with commit 54ed8ae.
This pull request is being automatically deployed with vercel-action

smackesey
smackesey approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@smackesey smackesey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jamiedemaria jamiedemaria merged commit 8978f18 into master Nov 10, 2023
4 checks passed
@jamiedemaria jamiedemaria deleted the benpankow/update-dagster-ssh branch November 10, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiedemaria jamiedemaria jamiedemaria left review comments

@smackesey smackesey smackesey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade dagster_ssh to pythonic resources
4 participants
@benpankow @jamiedemaria @caleboverman @smackesey