Skip to content

Commit

Permalink
[ui] Correct minstral typo and update Mistral logo for asset `kinds…
Browse files Browse the repository at this point in the history
…` tag (#27057)

## Summary & Motivation

This PR addresses two issues:
1. Corrects the typo "minstral" to "mistral" in the asset `kinds` tag.
This aligns with the official spelling on the [Mistral AI
website](https://mistral.ai/).
2. Updates the Mistral logo to the latest version, featuring left-side
shadow (24x24 px; 1,460 bytes).

<br/>

⚠️ **This PR introduces a breaking change due to the correction of the
"minstral" typo.**

## How I Tested These Changes

Launched the documentation website locally and verified that the typo
was fixed and the icon updated in the `Supported Icons` section (as in
the screenshot below).

<img width="1512" alt="Screenshot 2025-01-13 at 16 30 06"
src="https://github.com/user-attachments/assets/08dda0cd-6a2c-437e-b11c-8c05bc692549"
/>

## Changelog

> [ui] Correct `minstral` typo and update Mistral logo for asset `kinds`
tag
  • Loading branch information
dragos-pop authored Jan 15, 2025
1 parent 1750e8f commit 008393c
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 42 deletions.
2 changes: 1 addition & 1 deletion docs/content/concepts/metadata-tags/kind-tags.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ Some kinds are given a branded icon in the UI. We currently support nearly 200 u
| `metabase` | <Image src="/images/concepts/metadata-tags/kinds/icons/tool-metabase-color.svg" width={20} height={20} /> |
| `microsoft` | <Image src="/images/concepts/metadata-tags/kinds/icons/tool-microsoft-color.svg" width={20} height={20} /> |
| `minio` | <Image src="/images/concepts/metadata-tags/kinds/icons/tool-minio-color.svg" width={20} height={20} /> |
| `minstral` | <Image src="/images/concepts/metadata-tags/kinds/icons/tool-minstral-color.svg" width={20} height={20} /> |
| `mistral` | <Image src="/images/concepts/metadata-tags/kinds/icons/tool-mistral-color.svg" width={20} height={20} /> |
| `mlflow` | <Image src="/images/concepts/metadata-tags/kinds/icons/tool-mlflow-color.svg" width={20} height={20} /> |
| `modal` | <Image src="/images/concepts/metadata-tags/kinds/icons/tool-modal-color.svg" width={20} height={20} /> |
| `mongodb` | <Image src="/images/concepts/metadata-tags/kinds/icons/tool-mongodb-color.svg" width={20} height={20} /> |
Expand Down

This file was deleted.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 5 additions & 5 deletions js_modules/dagster-ui/packages/ui-core/src/graph/OpTags.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ import meta from './kindtag-images/tool-meta-color.svg';
import metabase from './kindtag-images/tool-metabase-color.svg';
import microsoft from './kindtag-images/tool-microsoft-color.svg';
import minio from './kindtag-images/tool-minio-color.svg';
import minstral from './kindtag-images/tool-minstral-color.svg';
import mistral from './kindtag-images/tool-mistral-color.svg';
import mlflow from './kindtag-images/tool-mlflow-color.svg';
import modal from './kindtag-images/tool-modal-color.svg';
import mongodb from './kindtag-images/tool-mongodb-color.svg';
Expand Down Expand Up @@ -323,7 +323,7 @@ export type KnownTagType =
| 'llama'
| 'meta'
| 'microsoft'
| 'minstral'
| 'mistral'
| 'montecarlo'
| 'openmetadata'
| 'oracle'
Expand Down Expand Up @@ -883,9 +883,9 @@ export const KNOWN_TAGS: Record<KnownTagType, KnownTag> = {
icon: microsoft,
content: 'Microsoft',
},
minstral: {
icon: minstral,
content: 'Minstral',
mistral: {
icon: mistral,
content: 'Mistral',
},
montecarlo: {
icon: montecarlo,
Expand Down

This file was deleted.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

2 comments on commit 008393c

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagster-docs ready!

✅ Preview
https://dagster-docs-651lo37p1-elementl.vercel.app
https://master.dagster.dagster-docs.io

Built with commit 008393c.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-asfeesvbg-elementl.vercel.app

Built with commit 008393c.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.