Added options to control argsort algorithm #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two options to control the actual sorting algorithm when calling
argsort. Nowmergesortis used both inload_dictionaryandset_threadsfunctions, but in my experiments. However, I noticed that changing the underlying algorithm might improve performance in some cases (without affecting results). This is not always the case, it really depends on the actual streamline configuration. Hence, I introduced this possibility to allow tuning this aspect in case of bad performance.The two options are called
sortDictionaryWithandsortThreadsWith, and can be set via theEvaluation.set_config()method. The possible values are:mergesort, 'stable' (which are equivalent), andquicksort.