Add multiplier lock functionality with double-click/hold gestures#84
Open
devalgupta404 wants to merge 7 commits intoda-Kai:developfrom
Open
Add multiplier lock functionality with double-click/hold gestures#84devalgupta404 wants to merge 7 commits intoda-Kai:developfrom
devalgupta404 wants to merge 7 commits intoda-Kai:developfrom
Conversation
…andle single tap vs double tap functionality
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #84 +/- ##
===========================================
+ Coverage 86.48% 86.72% +0.24%
===========================================
Files 26 26
Lines 1561 1612 +51
===========================================
+ Hits 1350 1398 +48
- Misses 211 214 +3 |
Contributor
Author
|
@da-Kai anything else to change?? |
Owner
Hi @devalgupta404, |
Owner
|
Here are some things i noticed:
|
Contributor
Author
|
@da-Kai please review it |
Owner
|
Fixed:
Errors:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lock multiplier with double click #37
Description
Implements the requested feature to allow locking the multiplier field with double-click or hold gestures, preventing it from automatically resetting to x1 after each numeric keypad entry.
Changes Made
isMultiplierLockedboolean to track locked stateBehavior
Fixes #37