Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evan dev #2

Merged
merged 18 commits into from
Mar 7, 2023
Merged

Evan dev #2

merged 18 commits into from
Mar 7, 2023

Conversation

eschechter
Copy link
Contributor

@eschechter eschechter commented Mar 3, 2023

I think what would be most helpful for @chrisrossi to do would be to review the docstrings and any glaring code style issues. We know the repo works functionally due to ipldstore, and I don't think there's time for Chris to really immerse into the codebase.

@chrisrossi
Copy link

As far as code formatting, I highly recommend the use of black for automatically formatting code to conform to PEP8. It is something of a standard now to add this and flake8 to tox to use as part of acceptance testing in continuous integration environments.

Copy link

@chrisrossi chrisrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! A few little niggles and some suggestions/commentary.

Copy link

@chrisrossi chrisrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Consider giving "mask_fun" a more transparent name, but there are no blockers here.

@eschechter eschechter merged commit 08e9fe2 into main Mar 7, 2023
@eschechter eschechter deleted the evan-dev branch March 7, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants