-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evan dev #2
Evan dev #2
Conversation
finished mask and bitmap_has tests
index function fix for tests
finish testing, except reading negative bytes
unfinished changes to iamap
creating prelim example of memory store for iamap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! A few little niggles and some suggestions/commentary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Consider giving "mask_fun" a more transparent name, but there are no blockers here.
I think what would be most helpful for @chrisrossi to do would be to review the docstrings and any glaring code style issues. We know the repo works functionally due to ipldstore, and I don't think there's time for Chris to really immerse into the codebase.