Repository navigation
chore: fix checkdoc verb warning on Emacs 30 - #84
Merged
Merged
Conversation
Emacs 30 runs checkdoc's verb check by default, and it flagged "starts" in the first sentence of vulpea-ui--widget-collapsed-p's docstring (added in #83), failing lint in the 30.2 CI job. Emacs 31.1 turned the check off by default, so lint passed on snapshot and on newer local builds. The docstring now says "should start", and Eldev turns the check on for every Emacs version, so lint gives the same result everywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#83 broke lint in the Emacs 30.2 CI job: checkdoc's verb check flagged "starts" in the first sentence of the
vulpea-ui--widget-collapsed-pdocstring. Emacs 31.1 turned that check off by default, so it passed on snapshot and on newer local builds.The docstring now says "should start". I also turned the check on in
Eldev, so lint gives the same result on every Emacs version and this kind of warning shows up locally too.