Repository navigation
fix: locate collection todo writes by ID, not stored position - #79
Merged
Merged
Conversation
Setting a todo state on several headings of one file went to each note's stored position. The first write shifts every heading below it, so later notes in the batch (and the undo replay) could get the state set on the wrong heading. The property writer already found its entry by ID; both now share vulpea-ui-collection--goto-entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting a todo state from a collection view (
T, and itsZundo) went to each note's stored position. When the selection has several headings from the same file, the first write shifts every heading below it, so later notes in the batch could get the state set on the wrong heading, or not at all.The property writer from #78 already finds its entry by ID; now both use the same
vulpea-ui-collection--goto-entryhelper, which falls back to the stored position when the ID isn't in the buffer.