Repository navigation
feat: show filtered meta keys as adaptive collection columns - #77
Merged
Merged
Conversation
A collection view without :columns derives its columns from the notes it shows, but never from the filter. A view filtered by a field, e.g. rating:*, did not show that field, and over notes without tags or todo it came up as just Title and Backlinks. Every key in the filter's :meta conditions now gets a (meta KEY) column after title and context. Views with explicit :columns are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A collection view without
:columnspicks its columns from the notes it shows, but ignores the filter. So filtering by a field (rating:*,country:France,/ m) never showed that field, and on notes without tags or todo the view was just Title and Backlinks. That looks broken, even though it's adaptive columns doing their thing.Now every key in the filter's
:metaconditions gets a(meta KEY)column, right after title and context. A key repeated in the filter gets one column. Views with explicit:columnsand a fixedvulpea-ui-collection-default-columnsare unchanged.README, docstring and CHANGELOG are updated.