Skip to content

Fix getEndLocation: Wrong max. scroll position #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qbasic16 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix getEndLocation: Wrong max. scroll position #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/angular-smooth-scroll.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,11 @@
} while (element);
}
location = Math.max(location - offset, 0);
/*
* If element location is at the bottom and withing the last window height, then we have to set end location to the highest possible and valid scroll position.
* This fixes the problem that animated scrolls are abruptedly stopped because the location was higher than the latest possible scroll location.
*/
location = Math.min(location, document.body.scrollHeight - window.innerHeight);
return location;
};

Expand Down