Fix #99: set fail_silently=True in CustomEmailHandler to prevent logg…#133
Open
subinita01 wants to merge 1 commit intocytoscape:masterfrom
Open
Fix #99: set fail_silently=True in CustomEmailHandler to prevent logg…#133subinita01 wants to merge 1 commit intocytoscape:masterfrom
subinita01 wants to merge 1 commit intocytoscape:masterfrom
Conversation
…vent logging from stopping When admin email delivery fails, the exception was propagating and halting the logging system entirely. The comment already stated the intent was fail_silently=True; the boolean was simply wrong. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Author
Problem
The inline comment already says "set fail_silently true" — the boolean FixChange Fixes #99 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ing from stopping
When admin email delivery fails, the exception was propagating and halting the logging system entirely. The comment already stated the intent was fail_silently=True; the boolean was simply wrong.