Fix: Search results stop after first model due to incorrect indentation (#127)#129
Closed
qzMalekuz wants to merge 4 commits intocytoscape:masterfrom
Closed
Fix: Search results stop after first model due to incorrect indentation (#127)#129qzMalekuz wants to merge 4 commits intocytoscape:masterfrom
qzMalekuz wants to merge 4 commits intocytoscape:masterfrom
Conversation
Author
|
Closing this PR in favor of a clean one with minimal commits and no unrelated changes. New PR: #130 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes search results returning only for the first model due to incorrect indentation and early return in
_xapian_search.Fixes #127
Changes
elseblockreturn all_resultsoutside the model loopTests
xapian, config, object fetch)Notes
Manual testing may show no results if search indices are not populated. The test verifies correct behavior.