Skip to content

Fix: Search results stop after first model due to incorrect indentation (#127)#129

Closed
qzMalekuz wants to merge 4 commits intocytoscape:masterfrom
qzMalekuz:fix/search-multi-model-results
Closed

Fix: Search results stop after first model due to incorrect indentation (#127)#129
qzMalekuz wants to merge 4 commits intocytoscape:masterfrom
qzMalekuz:fix/search-multi-model-results

Conversation

@qzMalekuz
Copy link
Copy Markdown

Summary

Fixes search results returning only for the first model due to incorrect indentation and early return in _xapian_search.

Fixes #127


Changes

  • Moved loop and related logic inside the else block
  • Moved return all_results outside the model loop
  • Ensured results are aggregated across all models

Tests

  • Added unit test to verify multi-model results
  • Mocked external dependencies (xapian, config, object fetch)

Notes

Manual testing may show no results if search indices are not populated. The test verifies correct behavior.

@qzMalekuz qzMalekuz closed this Mar 18, 2026
@qzMalekuz qzMalekuz deleted the fix/search-multi-model-results branch March 18, 2026 21:29
@qzMalekuz
Copy link
Copy Markdown
Author

Closing this PR in favor of a clean one with minimal commits and no unrelated changes.

New PR: #130 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search results processing stops after first model due to incorrect indentation

1 participant