FIX #122: create build/appstore/ migration dirs in Makefile build target#123
Open
kushvinth wants to merge 1 commit intocytoscape:masterfrom
Open
FIX #122: create build/appstore/ migration dirs in Makefile build target#123kushvinth wants to merge 1 commit intocytoscape:masterfrom
kushvinth wants to merge 1 commit intocytoscape:masterfrom
Conversation
The MIGRATION_MODULES setting in settings/local.py points migrations to
build/appstore/{apps,download,submit_app}. The Makefile build target was
missing the creation of these directories and their __init__.py files,
causing makemigrations and migrate to fail with:
ModuleNotFoundError: No module named 'build.appstore'
ValueError: Could not locate an appropriate location to create migrations package
This adds mkdir and touch commands to create the required package structure
before running any Django management commands.
Author
|
@coleslaw481, @matthiaskoenig, @sarthak-srivastava, @jingjingbic ,@AlexanderPico and other maintainers PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the build process in the
Makefileto better support the app store structure by creating necessary directories and__init__.pyfiles. This helps ensure Python recognizes these directories as packages and prevents potential import errors.Build process improvements:
buildtarget in theMakefileto create new directories forappstore/apps,appstore/download, andappstore/submit_appunder thebuilddirectory, and to add corresponding__init__.pyfiles to each directory and subdirectory to establish them as Python packages.Related Issues
build/Directory Blocks Project Setup #122