fix: resolve file descriptor leak in process_jar using context managers#121
Open
tirth707 wants to merge 1 commit intocytoscape:masterfrom
Open
fix: resolve file descriptor leak in process_jar using context managers#121tirth707 wants to merge 1 commit intocytoscape:masterfrom
tirth707 wants to merge 1 commit intocytoscape:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a resource leak in the app submission pipeline by ensuring the JAR ZipFile is always closed after reading/parsing META-INF/MANIFEST.MF, preventing WSGI worker exhaustion under repeated malformed uploads.
Changes:
- Wrap manifest read/parse in a
with archive:context manager so the zip file descriptor is reliably released on exceptions. - Remove the manual
archive.close()call (now handled by the context manager).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the file descriptor leak in the manifest parsing logic that contributes to WSGI worker exhaustion and "too many open files" server outages.
The fix transitions the zip archive handling in
submit_app/processjar.pyto a Python context manager (withstatement). This guarantees that the operating system immediately releases the file handler as soon as the manifest is read, even if a subsequent parsing error triggers an exception.Related Issue
Fixes #120
Testing & Proof
I verified this fix locally on macOS by profiling the Python process with
lsofwhile simulating a loop of 500 malformed app uploads.Before and After Profiling Comparison:

Implementing this strict context management prevents resource exhaustion and improves the resilience of the submission pipeline.