Skip to content

Commit

Permalink
document the fact OCL does not support google cloud storage
Browse files Browse the repository at this point in the history
We are happy to merge community code, but we don't consider it tested or supported.
  • Loading branch information
tsahee committed Oct 7, 2024
1 parent 79d6ec8 commit 1d643fd
Showing 1 changed file with 12 additions and 9 deletions.
21 changes: 12 additions & 9 deletions das/google_cloud_storage_service.go
Original file line number Diff line number Diff line change
@@ -1,21 +1,24 @@
package das

import (
googlestorage "cloud.google.com/go/storage"
"context"
"fmt"
"io"
"math"
"sort"
"time"

googlestorage "cloud.google.com/go/storage"
"github.com/google/go-cmp/cmp"
flag "github.com/spf13/pflag"
"google.golang.org/api/option"

"github.com/ethereum/go-ethereum/common"
"github.com/ethereum/go-ethereum/log"
"github.com/google/go-cmp/cmp"

"github.com/offchainlabs/nitro/arbstate/daprovider"
"github.com/offchainlabs/nitro/das/dastree"
"github.com/offchainlabs/nitro/util/pretty"
flag "github.com/spf13/pflag"
"google.golang.org/api/option"
"io"
"math"
"sort"
"time"
)

type GoogleCloudStorageOperator interface {
Expand Down Expand Up @@ -69,7 +72,7 @@ type GoogleCloudStorageServiceConfig struct {
var DefaultGoogleCloudStorageServiceConfig = GoogleCloudStorageServiceConfig{}

func GoogleCloudConfigAddOptions(prefix string, f *flag.FlagSet) {
f.Bool(prefix+".enable", DefaultGoogleCloudStorageServiceConfig.Enable, "enable storage/retrieval of sequencer batch data from an Google Cloud Storage bucket")
f.Bool(prefix+".enable", DefaultGoogleCloudStorageServiceConfig.Enable, "EXPERIMENTAL/unsupported - enable storage/retrieval of sequencer batch data from an Google Cloud Storage bucket")
f.String(prefix+".access-token", DefaultGoogleCloudStorageServiceConfig.AccessToken, "Google Cloud Storage access token")
f.String(prefix+".bucket", DefaultGoogleCloudStorageServiceConfig.Bucket, "Google Cloud Storage bucket")
f.String(prefix+".object-prefix", DefaultGoogleCloudStorageServiceConfig.ObjectPrefix, "prefix to add to Google Cloud Storage objects")
Expand Down

0 comments on commit 1d643fd

Please sign in to comment.