Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-14548: Add missing configuration for push-client #30

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

wcmjunior
Copy link
Contributor

In some situations, the configuration file for push-client may not be created. This workaround fixes the installation issue and will be removed after all sidecars are upgraded to v4.18 or later.

@yoursnerdly
Copy link
Contributor

Can you please share an example of what this config file used to look like (before it stopped getting packaged)?

@wcmjunior wcmjunior changed the title Add missing configuration for push-client ENG-14548: Add missing configuration for push-client Nov 18, 2024
@wcmjunior
Copy link
Contributor Author

Can you please share an example of what this config file used to look like (before it stopped getting packaged)?

This is what I got from a sidecar v4.10.5 I installed on a clean instance:

CYRAL_PUSH_CLIENT_FQDN="<SIDECAR_ID>"
CYRAL_PUSH_CLIENT_PROXY_URL=http://localhost:8069
ENDPOINTS=['localhost:8068']

@wcmjunior wcmjunior merged commit 74ca3cb into main Nov 18, 2024
1 check passed
@wcmjunior wcmjunior deleted the fix/ENG-14548 branch November 18, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants