RPM name changed #25
Merged
RPM name changed #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… script to find it and uninstall correctly
juniocezar
reviewed
Aug 29, 2024
| echo "Removing existing installation..." | ||
| dpkg -r cyral-sidecar > /dev/null 2>&1 | ||
| dpkg -r cyral-sidecar sidecar > /dev/null 2>&1 |
There was a problem hiding this comment.
if one of these packages are not present in the system, wont this command fail?
There was a problem hiding this comment.
with the -r option it continues:
sudo dpkg -r cyral-sidecar sidecar
dpkg: warning: ignoring request to remove cyral-sidecar which isn't installed
(Reading database ... 67831 files and directories currently installed.)
Removing sidecar (4.14.6-alpha) ...
Removed "/etc/systemd/system/multi-user.target.wants/cyral-alerter.service".
Removed "/etc/systemd/system/multi-user.target.wants/cyral-authenticator.service".
Removed "/etc/systemd/system/multi-user.target.wants/cyral-certificate-manager.service".
Removed "/etc/systemd/system/multi-user.target.wants/cyral-dispatcher.service".
Removed "/etc/systemd/system/multi-user.target.wants/cyral-forward-proxy.service".
Removed "/etc/systemd/system/multi-user.target.wants/cyral-oracle-wire.service".
Removed "/etc/systemd/system/multi-user.target.wants/cyral-pg-wire.service".
Removed "/etc/systemd/system/multi-user.target.wants/cyral-push-client.service".
Removed "/etc/systemd/system/multi-user.target.wants/cyral-service-monitor.service".
Removed "/etc/systemd/system/multi-user.target.wants/cyral-sqlserver-wire.service".
juniocezar
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
changes looks ok @vicagarcia . Anyway, this previous change from cyral-sidecar to just sidecar looks like a odd decision, unfortunately... sidecar could mean anything., from any vendor. lets see if wilson has any comments on the proposed changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from cyral-sidecar to sidecar, so the script looked for Cyral-sidecar before uninstalling and installing and it failed. I update the install script to find it using sidecar and uninstall correctly.
Tested this by doing an rpm install with the previous script twice:
After modifying the script:
Testing in ubuntu works as well: