chore: unify migrated packages #32819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se tsconfig.json instead of tsconfig.base as it has better IDE support. Also add a watcher
…se tsconfig.json instead of tsconfig.base as it has better IDE support. Also add a watcher
…se tsconfig.json instead of tsconfig.base as it has better IDE support. Also add a watcher
…se tsconfig.json instead of tsconfig.base as it has better IDE support. Also add a watcher
…se tsconfig.json instead of tsconfig.base as it has better IDE support. Also add a watcher
…se tsconfig.json instead of tsconfig.base as it has better IDE support. Also add a watcher
…se tsconfig.json instead of tsconfig.base as it has better IDE support. Also add a watcher
…se tsconfig.json instead of tsconfig.base as it has better IDE support. Also add a watcher
…se tsconfig.json instead of tsconfig.base as it has better IDE support. Also add a watcher
AtofStryker
changed the title
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/clean-up-migrated-packages
|
| Run status |
|
| Run duration | 19m 47s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
13
|
Pending
|
1102
|
Skipped
|
4
|
Passing
|
26755
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
46.02%
|
|
|---|---|
|
Untested elements
|
185
|
|
Tested elements
|
162
|
Accessibility
97.98%
|
|
|---|---|
|
Failed rules
|
4 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
101
|
jennifer-shehane
approved these changes
Oct 27, 2025
| "test-unit": "vitest run", | ||
| "tslint": "tslint --config ../ts/tslint.json --project .", | ||
| "watch": "tsc --watch" | ||
| "watch": "yarn build:cjs --watch & yarn build:esm --watch & yarn build:browser -w" |
There was a problem hiding this comment.
@AtofStryker Maybe not relevant to this PR, but I do see these warnings running this watch:
(!) Unresolved dependencies
https://rollupjs.org/troubleshooting/#warning-treating-module-as-external-dependency
@opentelemetry/sdk-trace-web (imported by "src/client.ts")
@opentelemetry/resources (imported by "src/client.ts" and "src/telemetry/index.ts")
@opentelemetry/sdk-trace-base (imported by "src/client.ts" and "src/processors/on-start-span-processor.ts")
@opentelemetry/api (imported by "src/span-exporters/websocket-span-exporter.ts" and "src/telemetry/index.ts")
@opentelemetry/exporter-trace-otlp-http (imported by "src/span-exporters/websocket-span-exporter.ts")
@opentelemetry/semantic-conventions (imported by "src/telemetry/index.ts")
@opentelemetry/core (imported by "src/span-exporters/console-trace-link-exporter.ts")
There was a problem hiding this comment.
This is due to rollup not actually bundling the node_modules inside the browser version of the telemetry package, which is expected currently. At least for now, we likely want to keep the warnings present since it describes the behavior
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Cleans up some of the migrated packages to
tsconfig.jsoninstead oftsconfig.base.jsonfor better IDE typescript supportSteps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Standardizes TS configs to emit declaration files, points package types to built outputs, adds watch scripts, and replaces lazy fs-extra require with direct import in resolve-dist.
"declaration": trueand point"types"to built outputs (cjs/index.d.ts) in@packages/config,@packages/errors,@packages/resolve-dist,@packages/scaffold-config,@packages/types.tsconfig.*.jsonto extendtsconfig.jsonacross packages (config,errors,icons,network-tools,network,resolve-dist,scaffold-config,telemetry,types).watchscripts (parallel CJS/ESM builds) toconfig,errors,scaffold-config,types; enhancetelemetrywatch to includebrowserbuild.packages/root/README.md: note about manually retriggering build (no watcher).packages/resolve-dist/lib/index.ts: replace lazyrequire('fs-extra')with directimport fs from 'fs-extra'.Written by Cursor Bugbot for commit 229ae60. This will update automatically on new commits. Configure here.