- 
                Notifications
    You must be signed in to change notification settings 
- Fork 3.4k
fix: let's try it out #32540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Draft
      
      
            jennifer-shehane
  wants to merge
  1
  commit into
  develop
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
visibility-optimizations
  
      
      
   
  
    
  
  
  
 
  
      
    base: develop
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Draft
            
            fix: let's try it out #32540
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
  cypress 
   | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project | cypress | 
| Branch Review | visibility-optimizations | 
| Run status |  | 
| Run duration | 43m 20s | 
| Commit |  | 
| Committer | Jennifer Shehane | 
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|  | 15 | 
|  | 11 | 
|  | 1015 | 
|  | 0 | 
|  | 19118 | 
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
| UI Coverage 44.73% | |
|---|---|
|  | 189 | 
|  | 157 | 
| Accessibility 97.71% | |
|---|---|
|  | 4 critical8 serious2 moderate2 minor | 
|  | 110 | 
Tests for review
 commands/actions/selectFile.cy.ts • 2 failed tests • 5x-driver-electron
   commands/actions/selectFile.cy.ts • 2 failed tests • 5x-driver-electron 
  | Test | Artifacts | |
|---|---|---|
| ... > can scroll to input | Test Replay | |
| ... > can specify scrollBehavior in options | Test Replay | |
The first 5 failed specs are shown, see all 673 specs in Cypress Cloud.
 commands/actions/click.cy.ts • 1 flaky test • 5x-driver-electron
   commands/actions/click.cy.ts • 1 flaky test • 5x-driver-electron 
  | Test | Artifacts | |
|---|---|---|
| ... > scrolls a container past a fixed position element when being covered | Test Replay | |
 commands/actions/trigger.cy.ts • 1 flaky test • 5x-driver-electron
   commands/actions/trigger.cy.ts • 1 flaky test • 5x-driver-electron 
  | Test | Artifacts | |
|---|---|---|
| ... > scrolls a container past a fixed position element when being covered | Test Replay | |
 commands/actions/selectFile.cy.ts • 1 flaky test • 5x-driver-electron
   commands/actions/selectFile.cy.ts • 1 flaky test • 5x-driver-electron 
  | Test | Artifacts | |
|---|---|---|
| ... > can scroll to label | Test Replay | |
 e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-inject-document-domain-chrome:beta
   e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-inject-document-domain-chrome:beta 
  | Test | Artifacts | |
|---|---|---|
| cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary | Test Replay | |
 e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-inject-document-domain-chrome
   e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-inject-document-domain-chrome 
  | Test | Artifacts | |
|---|---|---|
| cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary | Test Replay | |
The first 5 flaky specs are shown, see all 11 specs in Cypress Cloud.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Additional details
Performance Bottlenecks:
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?