perf: reduce the initial timeout for proxy connections, make configurable #31283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloneOfAlex
approved these changes
Apr 2, 2025
cacieprins
changed the title
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
cacie/fix/proxy-performance
|
| Run status |
|
| Run duration | 19m 06s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
8
|
Pending
|
1232
|
Skipped
|
0
|
Passing
|
32140
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.18%
|
|
|---|---|
|
Untested elements
|
185
|
|
Tested elements
|
163
|
Accessibility
92.63%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
887
|
jennifer-shehane
requested changes
Apr 16, 2025
Co-authored-by: Jennifer Shehane <[email protected]>
jennifer-shehane
approved these changes
Apr 16, 2025
AtofStryker
approved these changes
Apr 16, 2025
Co-authored-by: Bill Glesias <[email protected]>
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Prior to sending the API request to create a run, Cypress attempts to determine how best to make requests to the Cypress Cloud via a "preflight" request. This request is first made without the
CombinedAgentthat supports HTTP/S proxies, to one API domain. If this request fails, the second request is made to a different API domain, and uses theCombinedAgentthat uses proxy information in theHTTP_PROXY/HTTPS_PROXYenvironment variable.This is done to accommodate a wide variety of network configurations.
For network configurations that block non-proxied requests to the Cypress Cloud API, the request to create a run will always carry a 60 second overhead. However, this initial request is important to determine the network capabilities of the machine that is running the tests.
With this PR, the
CYPRESS_INITIAL_PREFLIGHT_TIMEOUTenvironment variable can be set. This can be reduced below the default 60 seconds to trim the overhead. This environment variable can also be set to -1, which will disable the non-proxied preflight request.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?