Skip to content

fix: Fix error when testing cross-origin code #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 3, 2024
Merged

fix: Fix error when testing cross-origin code #685

Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
59fab27
ignore cross-origin coverage
Nojay-Games Aug 19, 2023
199a4e6
Merge branch 'master' into master
jennifer-shehane Nov 15, 2023
1e036ad
empty commit
jennifer-shehane May 6, 2024
ab9868a
adding test
mschile Jun 19, 2024
8536c15
Merge branch 'master' into master
mschile Jun 19, 2024
f0a58ae
updates
mschile Jun 19, 2024
c1f9837
updates
mschile Jun 19, 2024
dc94d2f
update to node 20
mschile Jun 20, 2024
99dcf98
update config.yml
mschile Jul 3, 2024
4f398b7
updating package-lock.json
mschile Jul 3, 2024
9129e2c
updates
mschile Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions support.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,14 @@ const registerHooks = () => {
windowCoverageObjects = []

const saveCoverageObject = (win) => {
// accessing win.__coverage__ will error when testing cross-origin code
// because we don't control cross-origin code anyway, we can safely return
try {
win.__coverage__
} catch {
return
}

// if application code has been instrumented, the app iframe "window" has an object
const applicationSourceCoverage = win.__coverage__
if (!applicationSourceCoverage) {
Expand Down
Loading