Skip to content

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Aug 21, 2025

  • Log view doesn't apply for families
  • Info view is currently not working for families

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Docs PR not needed

@MetRonnie MetRonnie added this to the 2.9.0 milestone Aug 21, 2025
@MetRonnie MetRonnie self-assigned this Aug 21, 2025
@MetRonnie MetRonnie added the bug Something isn't working label Aug 21, 2025
@MetRonnie MetRonnie modified the milestones: 2.9.0, 2.10.0 Sep 4, 2025
@oliver-sanders oliver-sanders modified the milestones: 2.10.0, 2.11.0 Sep 17, 2025
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as working, mutations displayed as before, save for intended changes.

* @param {Object} tokens
* @returns {String}
* */
export function getType (tokens) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Unused and duplicates Tokens.lowestToken()?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicates

Probably?

AOTF and UID arrived at different times, wouldn't be surprised.

/**
* Convert camel case to words.
*/
export function camelToWords (camel) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced by lodash's startCase()

@MetRonnie MetRonnie requested a review from wxtim October 15, 2025 11:36
@wxtim wxtim merged commit cacd439 into cylc:master Oct 16, 2025
7 checks passed
@MetRonnie MetRonnie deleted the family-mutations branch October 16, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants