Skip to content

Conversation

@oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Jun 19, 2025

Should fix an integration failure reported in cylc/cylc-uiserver#672 (comment)

  • This worked under graphene v2 but not v3 for reasons unknown.
  • However, the default appears to be unnecessary which makes sense since it's List(LogRecords) not List(NonNull(LogRecords)).

Reviewer(s), please test the end-to-end functionality of this feature on the graphene v3 branches before approving.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

* This worked under graphene v2 but not v3 for reasons unknown.
* However, the default appears to be unnecessary which makes sense since
  it's `List(LogRecords)` not `List(NonNull(LogRecords))`.
@oliver-sanders oliver-sanders added this to the 8.5.0 milestone Jun 19, 2025
@oliver-sanders oliver-sanders self-assigned this Jun 19, 2025
@oliver-sanders oliver-sanders requested a review from wxtim June 19, 2025 13:49
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Merged with Warning triangles feature branch & master
  • Manually tested warning 📐
  • Read code

@wxtim wxtim self-requested a review June 19, 2025 14:36
@oliver-sanders
Copy link
Member Author

I'm going to sneak this in on one review so we can fix master and unblock the UIS PR.

@dwsutherland, if you get a chance to take a peek at this one sometime, lemme know if there's any reason we shouldn't fix it this way, cheers.

@oliver-sanders oliver-sanders merged commit 01c2308 into cylc:master Jun 19, 2025
37 of 38 checks passed
@oliver-sanders oliver-sanders deleted the schema-fix branch June 19, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants