Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Vite 5 #82

Merged
merged 9 commits into from
Dec 30, 2023
Merged

Update to Vite 5 #82

merged 9 commits into from
Dec 30, 2023

Conversation

giacomorebonato
Copy link
Contributor

@giacomorebonato giacomorebonato commented Nov 20, 2023

All tests passing

Screenshot 2023-11-27 at 13 31 07

@giacomorebonato giacomorebonato marked this pull request as ready for review November 20, 2023 16:11
@giacomorebonato
Copy link
Contributor Author

@cyco130 do you think that I could ask for a review of this?

Thanks for this awesome tool

@TylorS
Copy link

TylorS commented Dec 4, 2023

I've been building some stuff atop of vavite for a while, and I'd be very interested in seeing this or similar make its way through the pipeline 😄

Anything I could do to be of more help?

@giacomorebonato
Copy link
Contributor Author

I created a fork, if you want to try it out and contribute @TylorS

I don't mean to be unpolite to this great project in any way and it's the first time that I fork something published on npm:

  • I am happy to deprecate the fork and contribute here if it's welcome
  • if I didn't give the right credit to @cyco130 , please reach out and I'll address that. That's not intentional.

@TylorS
Copy link

TylorS commented Dec 29, 2023

It took me a little while to get back to working on abstractions related to vavite, and I tested out your fork @giacomorebonato, and so far after about an hour of using it I haven't run into any issues and everything seems to be working great

@cyco130 cyco130 merged commit bfad5a5 into cyco130:main Dec 30, 2023
6 checks passed
@cyco130
Copy link
Owner

cyco130 commented Dec 30, 2023

Sorry for the late response and thank you for your contribution. I will release soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants