Skip to content

Conversation

@EdwardCooke
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings December 21, 2025 07:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Kubernetes configuration to comply with CIS Benchmark 1.12, adding security-hardening configurations for seccomp profiles and service account token expiration controls.

  • Added seccompDefault kubelet configuration to enable seccomp by default (CIS 4.2.14)
  • Added service-account-extend-token-expiration API server argument set to false (CIS 1.2.30)
  • Updated README to reflect CIS Benchmark version 1.12 compliance

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
roles/kubernetes-worker/templates/worker-kubeadm.yaml.j2 Added seccompDefault configuration and fixed token variable spacing
roles/kubernetes-defaults/defaults/main.yml Added default variables for seccomp and service account token expiration
roles/kubernetes-control-plane/templates/kubeadm-join-1.34.yaml.j2 Added seccompDefault configuration using variable reference
roles/kubernetes-control-plane/templates/kubeadm-join-1.33.yaml.j2 Added seccompDefault configuration using variable reference
roles/kubernetes-control-plane/templates/kubeadm-init-1.34.yaml.j2 Added seccompDefault and service-account-extend-token-expiration configurations
roles/kubernetes-control-plane/templates/kubeadm-init-1.33.yaml.j2 Added seccompDefault and service-account-extend-token-expiration configurations
README.md Updated documentation to reference CIS Benchmark 1.12

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@cookew cookew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EdwardCooke EdwardCooke merged commit ea9de44 into main Dec 21, 2025
7 checks passed
@EdwardCooke EdwardCooke deleted the ec-cis1.12 branch December 21, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants