-
Notifications
You must be signed in to change notification settings - Fork 4
Update to CIS Benchmark 1.12 #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Kubernetes configuration to comply with CIS Benchmark 1.12, adding security-hardening configurations for seccomp profiles and service account token expiration controls.
- Added
seccompDefaultkubelet configuration to enable seccomp by default (CIS 4.2.14) - Added
service-account-extend-token-expirationAPI server argument set to false (CIS 1.2.30) - Updated README to reflect CIS Benchmark version 1.12 compliance
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| roles/kubernetes-worker/templates/worker-kubeadm.yaml.j2 | Added seccompDefault configuration and fixed token variable spacing |
| roles/kubernetes-defaults/defaults/main.yml | Added default variables for seccomp and service account token expiration |
| roles/kubernetes-control-plane/templates/kubeadm-join-1.34.yaml.j2 | Added seccompDefault configuration using variable reference |
| roles/kubernetes-control-plane/templates/kubeadm-join-1.33.yaml.j2 | Added seccompDefault configuration using variable reference |
| roles/kubernetes-control-plane/templates/kubeadm-init-1.34.yaml.j2 | Added seccompDefault and service-account-extend-token-expiration configurations |
| roles/kubernetes-control-plane/templates/kubeadm-init-1.33.yaml.j2 | Added seccompDefault and service-account-extend-token-expiration configurations |
| README.md | Updated documentation to reference CIS Benchmark 1.12 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cookew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.