Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New config option "initial_repl_sleep_delay_usec" #88

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

arosh
Copy link
Collaborator

@arosh arosh commented Jan 29, 2024

This commit adds a new configuration option, initial_repl_sleep_delay, which allows the user to specify the sleep delay for the GC thread during the initial replication process. This helps prevent errors related to the replication buffer being full.

This commit adds a new configuration option, initial_repl_sleep_delay, which allows the developer to specify the sleep delay for the GC thread during the initial replication process. This helps prevent errors related to the replication buffer being full.
@arosh arosh force-pushed the throttle-initial-replication branch from 2211a93 to 10302cb Compare January 29, 2024 05:24
Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/memcache/gc.cpp Outdated Show resolved Hide resolved
etc/yrmcds.conf Outdated Show resolved Hide resolved
@arosh arosh marked this pull request as ready for review January 29, 2024 09:07
@arosh arosh changed the title New config option "initial_repl_sleep_delay" New config option "initial_repl_sleep_delay_usec" Jan 29, 2024
ymmt2005
ymmt2005 previously approved these changes Jan 29, 2024
Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymmt2005 ymmt2005 merged commit a0ab933 into cybozu:master Jan 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants