Fetch display name from the Phonebook instead showing 'Unknown Caller… #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR - will review and merge this week. |
cybex-dev
reviewed
Mar 19, 2025
cybex-dev
reviewed
Jun 16, 2025
|
|
||
| let callUpdate = CXCallUpdate() | ||
| callUpdate.remoteHandle = callHandle | ||
| callUpdate.localizedCallerName = clients[from] ?? self.clients["defaultCaller"] ?? defaultCaller | ||
| /// Apparently localizedCallerName overrides remoteHandle, so it was commented out fix "Unknown Caller" issue. | ||
| // callUpdate.localizedCallerName = from ?? self.clients["defaultCaller"] ?? defaultCaller |
There was a problem hiding this comment.
This won't respect saved clients, integrating this change will affect others making use of the registerClient feature.
I'm working on an different approach allowing the developer to interpret the name directly from the custom parameters, clients map, etc.
| let callHandle = CXHandle(type: .generic, value: from) | ||
| func reportIncomingCall(from: String, uuid: UUID) { | ||
| // Using .phoneNumber to fetch display name from the Phonebook if the number is saved otherwise show literal string 'from'. | ||
| let callHandle = CXHandle(type: .phoneNumber, value: from) |
There was a problem hiding this comment.
Great addition, though not all apps using twilio_voice make use of contacts or "from" values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…' everytime.
Fixes #214 #202