Feature/2025 04 02 custom mining with verification#5
Closed
Feature/2025 04 02 custom mining with verification#5
Conversation
There was a problem hiding this comment.
Copilot reviewed 1 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (5)
- src/Qubic.vcxproj: Language not supported
- src/Qubic.vcxproj.filters: Language not supported
- src/network_messages/all.h: Language not supported
- src/network_messages/custom_mining.h: Language not supported
- src/qubic.cpp: Language not supported
Comments suppressed due to low confidence (1)
doc/protocol.md:53
- [nitpick] The new message name 'RequestedCustomMiningVerification' could be inconsistent with existing naming patterns such as 'RequestAssets'. Consider renaming it to 'RequestCustomMiningVerification' for consistency.
+- `RequestedCustomMiningVerification`, type 55, defined in `custom_mining.h`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.