[Bug #32446] Assuming identity is very slow #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* closes flyerhzm#67 * warden#set_user sets current_sign_in_at, last_sign_in_at, current_sign_in_ip, sign_in_count, current_sign_in_ip, last_sign_in_ip * use SessionSerialializer#store to bypass the updating of these columns * thanks rajagopals@7437c5c
Devise provider- don't store sign_in details
security 💂♂️
This reverts commit fb611a2.
This reverts commit e6147fb.
* re-implement e6147fb (reverted in d18b453) * closes flyerhzm#67 * warden#set_user sets current_sign_in_at, last_sign_in_at, current_sign_in_ip, sign_in_count, current_sign_in_ip, last_sign_in_ip * use SessionSerialializer#store to bypass the updating of these columns * fix tests
Devise provider- don't store sign_in details
SwitchUser.all_users only selects identifier and name columns. SwitchUser.data_sources.find_scope_id only queries that user.
…d str 2. Don't attempt to query db if scope str isn't in scope_id str
DataSource#find_scope_id bug fixes
replace select option to group option
fix grouped_options_for_select bug for rails 3.2
support capybara
add class and style options to switch_user_select
fix selected_user_of_helper bug
Make the javascript redirect respect the relative_url_root
add ability to store_sign_in info with devise provider
`#remember_user`. We need to be able to tell the gem that we want the user to be remembered so that we can switch back to it. It was unclear how it should've been done, so this is making sure that we don't have to make two calls to the `SwitchUser API`, just to make sure the original user will be remembered. Related Issue: flyerhzm/issues/55
fix scope in devise provider
Rails.env.production?
Fix small issue related to user scope on warden Change behaviour to allow remember=true to be called on URL
Fix typo in config instructions
Update docs about before_action when Rails < 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the gem to latest version.