This repository was archived by the owner on May 16, 2024. It is now read-only.
upstream merge #12
Open
upstream merge #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(android): fix onVideoLoad event naturalSize field key * fix(android): fix onVideoLoad event currentTime field key
* Rename .java to .kt * refactor(android): migrate AudioBecomingNoisyReceiver to Kotlin * fix: lint error * chore: initialize appContext with context.applicationContext
…otlin (#3995) * Rename .java to .kt * refactor(android): migrate ReactExoplayerLoadErrorHandlingPolicy to Kotlin
* Rename .java to .kt * refactor(android): migrate ReactExoplayerConfig to Kotlin
* Rename .java to .kt * refactor(android): migrate AudioOutput to Kotlin * fix: lint error * refactor: rename of variables
* Rename .java to .kt * chore(android): migrate FullScreenPlayerView to Kotlin * refactor: onBackPressed function * refactor: fullScreen button function * fix: lint error * chore: revert onBackPressed function
Co-authored-by: Olivier Bouillet <[email protected]>
…3996) * Rename .java to .kt * refactor(android): migrate BecomingNoisyListener interface to Kotlin * remove: java file (AudioBecomingNoisyReceiver.java)
* fix: disable coreLibraryDesugaringEnabled by default
* perf: ensure we do not provide callback to native if no callback provided from app * chore: rework bufferConfig to make it more generic and reduce ReactExoplayerView code size * chore: improve issue template * fix(android): avoid video view flickering at playback startup * fix: ensure player doesn't start when view is unmounted * Fix/ensure view drop stop playback startup (#3875) * fix: ensure player doesn't start when view is unmounted * chore: fix app boot due to missing registered events * chore: fix linter * chore: fix build * fix: handle code review feedbacks * chore: revert previous change to handle only necessary fix
…oster as custom component (#3972)
* feat(android): add error handling for Kotlin version mismatch * fix: lint error * refactor: use variables from gradle file * chore: downgrade required Kotlin version * refactor: check Kotlin version * refactor: kotlin variables in build.gradle * refactor: kotlin variables in build.gradle * chore(doc): update document * chore: add dependency to build.gradle for a specific version of react-native * fix: remove additional dependency
…spelling error (#4014) (#4042) * fix(android): updated getLicense call to work with new syntax, and fixed spelling error (#4014) * fix(android): corrected error with my refactor (#4014) * fix(android): Removed trailing space (#4014) * fix(ios): Refactored following review (#4014) * fix(ios): Lint tidy (#4014) * fix(ios): Removed incorrect semi-colon (#4014) * fix(ios): Fixed more lint errors (#4014) --------- Co-authored-by: Darren Taft <[email protected]>
* fix metadata update race * merge nowPlayingInfo instead of overriding it * update method name * fix code style
* Rename .java to .kt * refactor(android): migrate ReactExoplayerViewManager to Kotlin * fix: lint error * refactor: setPreventsDisplaySleepDuringVideoPlayback function
…function (#4054) * fix(android): return value for getCurrentPosition function * fix: remove additional casting
* fix(ios): override source metadata with custom metadata * lint code
…e when using Google IMA ads in react-native-video. (#4574) Co-authored-by: Varuzhan Khachatryan <[email protected]>
Co-authored-by: Pieczasz <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
66 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.