feat: In-App SSE #975
Open
feat: In-App SSE #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. |
SDK binary size reports 📊SDK binary size of this PRSDK binary size diff report vs. main branch |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #975 +/- ##
==========================================
+ Coverage 65.40% 67.87% +2.46%
==========================================
Files 172 182 +10
Lines 8024 9400 +1376
==========================================
+ Hits 5248 6380 +1132
- Misses 2776 3020 +244 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| await setupInitialState() | ||
|
|
||
| logger.logWithModuleTag("SseLifecycleManager: Lifecycle manager started successfully", level: .info) | ||
| } |
There was a problem hiding this comment.
SseLifecycleManager.start() not idempotent causes duplicate observers
The start() method in CioSseLifecycleManager is not idempotent. If called multiple times, setupNotificationObservers() appends additional observers to notificationObservers, and subscribeToSseFlagChanges()/subscribeToUserIdChanges() create new subscribers while orphaning old ones. While the singleton pattern makes this unlikely in production, calling start() multiple times would accumulate notification observers and cause duplicate handling of foreground/background events. Adding a guard like guard !hasStarted else { return } would make this method safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection of approved PRs for SSE implementation.
Note
Introduces SSE-based real-time delivery for in-app messages with robust lifecycle and reliability controls.
SseService(EventSource wrapper),SseConnectionManager,SseRetryHelper,HeartbeatTimer, and utilities (AsyncStreamBackport,Sleeper,ApplicationStateProvider)SseLifecycleManagerto start/stop SSE on app foreground/background and user identification changesuseSseandshouldUseSse; new actionsetSseEnabled; reducer/state updated accordinglyGistnow manages polling vs SSE: subscribes touseSse,userId, andpollInterval; stops polling when SSE active for identified users; continues polling for anonymous usersQueueManagerreadsx-gist-queue-polling-intervaland newx-cio-use-sseresponse header to update statesseAPIendpoints; DI graph updated to register new componentsLDSwiftEventSource(Podspec + SPM), and links it toCioMessagingInApptargetWritten by Cursor Bugbot for commit 2d878f0. This will update automatically on new commits. Configure here.