Skip to content

chore: comprehensive maintenance pass #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
currentsuspect wants to merge 1 commit into from
Closed

chore: comprehensive maintenance pass #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ jobs:
build-linux:
name: Linux (GCC)
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -58,6 +59,7 @@ jobs:
build-windows:
name: Windows (MSVC)
runs-on: windows-latest
timeout-minutes: 45
steps:
- uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -100,6 +102,7 @@ jobs:
build-macos:
name: macOS (Clang)
runs-on: macos-latest
timeout-minutes: 45
continue-on-error: true
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -141,6 +144,7 @@ jobs:
format-check:
name: Code Formatting
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- uses: actions/checkout@v4

Expand All @@ -161,6 +165,7 @@ jobs:
static-analysis:
name: Static Analysis (clang-tidy)
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
- uses: actions/checkout@v4

Expand Down
2 changes: 0 additions & 2 deletions AestraAudio/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ cmake_minimum_required(VERSION 3.22)

project(AestraAudio VERSION 1.0.0 LANGUAGES CXX)

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

# Prevent Windows min/max macros from conflicting with std::min/std::max
Comment on lines -5 to 6
Copy link
Copy Markdown
Contributor

@qodo-code-review qodo-code-review bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

2. Standalone build loses c++17 🐞 Bug ✓ Correctness

AestraAudio’s CMakeLists no longer enforces C++17, so configuring AestraAudio as a standalone CMake
project can compile with the compiler default and fail on C++17-only constructs used throughout
AestraAudio.
Agent Prompt 
### Issue description
Removing `set(CMAKE_CXX_STANDARD 17)` from `AestraAudio/CMakeLists.txt` breaks building the AestraAudio module as a standalone project because the code uses C++17-only features.

### Issue Context
When building from the repo root, `CMakeLists.txt` sets C++17 globally, but AestraAudio is also a standalone CMake project (`project(AestraAudio ...)`) and should remain buildable on its own.

### Fix Focus Areas
- AestraAudio/CMakeLists.txt[1-10]
- AestraAudio/CMakeLists.txt[318-399]

### Implementation notes
Preferred fix:
- Add `target_compile_features(AestraAudioCore PUBLIC cxx_std_17)` (and similarly for `AestraAudioWin`/`AestraAudioLinux` if needed) so the requirement propagates to consumers.

Acceptable alternative:
- Restore `set(CMAKE_CXX_STANDARD 17)` / `set(CMAKE_CXX_STANDARD_REQUIRED ON)` in AestraAudio, ideally guarded to avoid downgrading a parent project (e.g., only set if `CMAKE_CXX_STANDARD` is not already defined).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

if(WIN32)
Expand Down
Loading
Loading