Skip to content

Updated contract metadata #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 28, 2022
Merged

Updated contract metadata #102

merged 9 commits into from
Mar 28, 2022

Conversation

sekaiking
Copy link
Contributor

@sekaiking sekaiking commented Mar 4, 2022 •
edited
Loading

related to curaOS/BSCS#53

@vercel
Copy link

vercel bot commented Mar 4, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/curaos/cura-contract-docs/9NLGiXbfS1LH41QDtoK4KTLrAaTL
✅ Preview: https://cura-contract-docs-git-contractmetadata-curaos.vercel.app

This was linked to issues Mar 4, 2022
Minify Creative Code saved in contract #89
Closed
Store script in a better structure #91
Closed
@sekaiking sekaiking mentioned this pull request Mar 4, 2022
Open
@sekaiking sekaiking requested review from AshenI99 and bestatigen March 4, 2022 10:14
@sekaiking sekaiking changed the title Contract metadata Updated contract metadata Mar 4, 2022
bestatigen
bestatigen reviewed Mar 7, 2022
View reviewed changes
bestatigen
bestatigen requested changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@bestatigen bestatigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to add too much overhead now, so let's keep packages_script as string.

@AshenI99 AshenI99 requested a review from bestatigen March 28, 2022 10:24
bestatigen
bestatigen approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@bestatigen bestatigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS

@AshenI99 AshenI99 merged commit 9f20478 into master Mar 28, 2022
@AshenI99 AshenI99 deleted the contract_metadata branch March 28, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AshenI99 AshenI99 AshenI99 approved these changes

@bestatigen bestatigen bestatigen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Store script in a better structure Minify Creative Code saved in contract

3 participants

@sekaiking @bestatigen @AshenI99