Proposal for schema stitching at runtime - prevent links from getting added twice #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a bigger effort discussed in the cult-of-coders/apollo repo. When I attempted to initialize the apollo package a second time at runtime Grapher throws because it will addLinks to collections that already have links. I hoping to learn the right way to do it via feedback to these PRs but I wanted to show some effort up front. Like a proof of concept.
My initial thoughts are that this is a very brittle check and links could be different in more way than the
field.name. So looking for advice on a better way to "refresh" grapher with a new graphql schema.