[codex] Add legacy uppercase marker audit#52
Draft
zack-bolich wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
tools/legacy_caps_audit.pyto enforce that files containinglegacyreferences also include an uppercaseLEGACYmarker in a comment-like line. Adds focusedLEGACY audit markercomments to the files flagged by the new audit so the script exits cleanly.Fixes #12.
Changes
tools/legacy_caps_audit.py.LEGACYmarker comments to files that already contained legacy references.Testing
python tools\legacy_caps_audit.pyon Windows: passed.python3 tools/legacy_caps_audit.pyin Ubuntu WSL: passed.python -m py_compile tools\legacy_caps_audit.py: passed.git diff --check: passed.Build diagnostic note
I attempted the required
python3 build.pyvalidation in both Windows and Ubuntu WSL. In both environments, the build reachedChecking encryptly diagnostics...and stalled in theencryptlydiagnostic step. Because that step did not finish, I could not produce a new realdiagnostic/build-*.logdartifact for this submission. The repository currently only contains the existing placeholderdiagnostic/build-00000000.logdanddiagnostic/build-00000000.json, which I did not use as new validation evidence.Checklist