Add preliminary support for rendering run hooks #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cucumber-react-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
davidjgoss
reviewed
Sep 28, 2025
There was a problem hiding this comment.
Thanks for doing this. Looks good, but some fairly minor feedback and suggestions.
I noticed on the story for BeforeAll errors that the <FilteredDocuments> component renders "nothing found" when really there are just no test cases at all - I'm reworking the search/filtering behaviour on another branch so I'll aim to take care of this over there, but I'm glad this change shone a light on it.
|
|
||
| export const RunHooksList: FunctionComponent<{ children: ReactNode }> = ({ children }) => { | ||
| return ( | ||
| <ol aria-label="RunHooks" className={styles.hooks}> |
There was a problem hiding this comment.
I'd leave it to consumers to decide if/how to label this section with e.g. headings.
There was a problem hiding this comment.
How were you thinking? EG. a aria-label prop?
Leave this to the consumer.
This served little to no purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
A list below GherkinDocument, showing
BeforeAll(..)andAfterAll(..)hooks.⚡️ What's your motivation?
Errors in
BeforeAll(..)leads to a merely empty document - this shows why, in addition to adding support for presenting run hooks attachments.🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Anything, really. I'm new to the project and even ladle.
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.