Skip to content

Commit 6ee4923

Browse files
authored
Bump cucumber dependencies (#407)
1 parent 290fd28 commit 6ee4923

File tree

5 files changed

+23
-26
lines changed

5 files changed

+23
-26
lines changed

package-lock.json

Lines changed: 12 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"dependencies": {
2929
"@cucumber/gherkin-utils": "10.0.0",
3030
"@cucumber/messages": "29.0.1",
31-
"@cucumber/query": "14.0.1",
31+
"@cucumber/query": "14.3.0",
3232
"@cucumber/tag-expressions": "6.2.0",
3333
"@fortawesome/fontawesome-svg-core": "6.2.1",
3434
"@fortawesome/free-solid-svg-icons": "6.2.1",
@@ -57,9 +57,9 @@
5757
"react-dom": "~18"
5858
},
5959
"devDependencies": {
60-
"@cucumber/compatibility-kit": "^22.0.1",
60+
"@cucumber/compatibility-kit": "^23.0.0",
6161
"@cucumber/fake-cucumber": "^18.1.0",
62-
"@cucumber/gherkin": "^35.0.0",
62+
"@cucumber/gherkin": "^35.1.0",
6363
"@cucumber/gherkin-streams": "^6.0.0",
6464
"@cucumber/message-streams": "^4.0.1",
6565
"@eslint/compat": "^1.2.7",

src/components/app/ExecutionSummary.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ Platform: [email protected]`)
7979
</EnvelopesProvider>
8080
)
8181

82-
expect(screen.getByText('55.5% (5 / 9) passed')).to.be.visible
82+
expect(screen.getByText('71.4% (5 / 7) passed')).to.be.visible
8383
})
8484

8585
it('should include the job link', () => {

src/components/app/SearchBar.spec.tsx

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -125,9 +125,8 @@ describe('SearchBar', () => {
125125
</EnvelopesProvider>
126126
)
127127

128-
expect(getAllByRole('checkbox')).to.have.length(3)
128+
expect(getAllByRole('checkbox')).to.have.length(2)
129129
expect(getByRole('checkbox', { name: 'passed 5' })).to.be.visible
130-
expect(getByRole('checkbox', { name: 'undefined 2' })).to.be.visible
131130
expect(getByRole('checkbox', { name: 'failed 2' })).to.be.visible
132131
getAllByRole('checkbox').forEach((checkbox: HTMLInputElement) => {
133132
expect(checkbox).to.be.checked
@@ -142,26 +141,25 @@ describe('SearchBar', () => {
142141
</EnvelopesProvider>
143142
)
144143

145-
await userEvent.click(getByRole('checkbox', { name: 'undefined 2' }))
144+
await userEvent.click(getByRole('checkbox', { name: 'failed 2' }))
146145

147146
expect(onChange).to.have.been.calledOnceWithExactly({
148147
query: '',
149-
hideStatuses: [TestStepResultStatus.UNDEFINED],
148+
hideStatuses: [TestStepResultStatus.FAILED],
150149
})
151150
})
152151

153152
it('should show hidden statuses as unchecked', () => {
154153
const { getByRole } = render(
155154
<EnvelopesProvider envelopes={examplesTablesFeature}>
156155
<TestableSearchBar
157-
defaultValue={{ query: '', hideStatuses: [TestStepResultStatus.UNDEFINED] }}
156+
defaultValue={{ query: '', hideStatuses: [TestStepResultStatus.FAILED] }}
158157
/>
159158
</EnvelopesProvider>
160159
)
161160

162161
expect(getByRole('checkbox', { name: 'passed 5' })).to.be.checked
163-
expect(getByRole('checkbox', { name: 'failed 2' })).to.be.checked
164-
expect(getByRole('checkbox', { name: 'undefined 2' })).not.to.be.checked
162+
expect(getByRole('checkbox', { name: 'failed 2' })).not.to.be.checked
165163
})
166164

167165
it('updates the search context when a status is rechecked', async () => {
@@ -171,7 +169,7 @@ describe('SearchBar', () => {
171169
<TestableSearchBar
172170
defaultValue={{
173171
query: '',
174-
hideStatuses: [TestStepResultStatus.FAILED, TestStepResultStatus.UNDEFINED],
172+
hideStatuses: [TestStepResultStatus.FAILED, TestStepResultStatus.PASSED],
175173
}}
176174
onChange={onChange}
177175
/>
@@ -182,7 +180,7 @@ describe('SearchBar', () => {
182180

183181
expect(onChange).to.have.been.calledOnceWithExactly({
184182
query: '',
185-
hideStatuses: [TestStepResultStatus.UNDEFINED],
183+
hideStatuses: [TestStepResultStatus.PASSED],
186184
})
187185
})
188186
})

src/components/app/StatusesSummary.spec.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ describe('StatusesSummary', () => {
1616

1717
expect(getAllByRole('listitem').map((li) => li.textContent)).to.deep.eq([
1818
'5 passed',
19-
'2 undefined',
2019
'2 failed',
2120
])
2221
})

0 commit comments

Comments
 (0)