feat: Add Requirement Tag for XRay Import #93
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgrohmann
force-pushed
the
feat/requirement-tag
branch
from
36ac37f to
5f89809
Compare
mpkorstanje
reviewed
Sep 11, 2025
There was a problem hiding this comment.
Implementation wise this looks okay. But as discussed in #92 this would be better of in a fork.
With the current testing strategy you can't add more samples easily. They're created by running Cucumber against a collection of samples in the compatibility-kit.
You can also generate samples but running an existing cucumber implementation. For example see the cucumber-json-formatter, specifically:
- https://github.com/cucumber/cucumber-json-formatter/tree/main/testdata/cucumber-jvm
- https://github.com/cucumber/cucumber-json-formatter/blob/main/testdata/cucumber-jvm/default-java.mk
If you need help, let me know!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I didn't quite get how the testdata things work and if you can even add your own tags somehow.
See #92