Skip to content

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Nov 15, 2024

🤔 What's changed?

While the timestamp attribute is not part of the JUnit or Surefire XSD in practice it seems to be a common enough property[1] that we can add it without expecting any of the popular tools to break.

Closes: #44

  1. https://github.com/testmoapp/junitxml

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

While the timestamp attribute is not part of the JUnit or Surefire XSD
in practice it seems to be a common enough property[1] that we can add
it without expecting any of the popular tools to break.

Closes: #44

 1. https://github.com/testmoapp/junitxml
@davidjgoss
Copy link
Contributor

JS implementation done!

@mpkorstanje
Copy link
Contributor Author

Great then we just have to update the docs.

@mpkorstanje mpkorstanje marked this pull request as ready for review November 15, 2024 20:27
@mpkorstanje mpkorstanje merged commit aa1608c into main Nov 16, 2024
8 checks passed
@mpkorstanje mpkorstanje deleted the add-timestamp branch November 16, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JUnit XML should have timestamp attrubute

2 participants