Merged
Conversation
app/src/main/java/com/cornellappdev/score/components/EmptyState.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/EmptyState.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/EmptyState.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/EmptyState.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/EmptyState.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/EmptyState.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
AndrewCheung360
requested changes
Oct 25, 2025
Member
AndrewCheung360
left a comment
AndrewCheung360
left a comment
There was a problem hiding this comment.
Overall, nice work! This UI looks very involved, and it's very close to the figma designs. I just noted a few things that we might want to change to better match the designs or improve their implementation. A decent amount of the comments are just nits as well.
conniecliu
reviewed
Oct 25, 2025
app/src/main/java/com/cornellappdev/score/components/HighlightsFilter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/screen/HighlightsScreen.kt
Outdated
Show resolved
Hide resolved
Collaborator
zachseidner1
left a comment
zachseidner1
left a comment
There was a problem hiding this comment.
Nice work overall! I think Andrew and Connie got most of it but there are a couple of additional improvements I noticed that could be made
app/src/main/java/com/cornellappdev/score/screen/HighlightsScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/screen/HighlightsScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/HighlightsFilter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/screen/HighlightsScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/EmptyState.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/highlights/HighlightsSearchBar.kt
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/highlights/HighlightsSearchBar.kt
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/highlights/HighlightsSearchBar.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/highlights/VideoHighlightsCard.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/highlights/VideoHighlightsCard.kt
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/highlights/VideoHighlightsCard.kt
Outdated
Show resolved
Hide resolved
AndrewCheung360
approved these changes
Nov 3, 2025
Member
AndrewCheung360
left a comment
AndrewCheung360
left a comment
There was a problem hiding this comment.
I left some comments on a couple things I noticed that could be worth addressing, but overall, nice work! There were a lot of comments from 3 people lol, so thank you for going through them all!
Contributor
|
good work!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Highlights screen UI
Changes Made
Highlights Card UI + main highlights screen
Test Coverage
Previews visually match the figma
Next Steps (delete if not applicable)
Screenshots (delete if not applicable)