Merged
Conversation
* Add missing border * Bump material version in preparation for pull to refresh * Fix border on home and past, fix carousel # Conflicts: # app/src/main/java/com/cornellappdev/score/screen/HomeScreen.kt # app/src/main/java/com/cornellappdev/score/screen/PastGamesScreen.kt
… Amy/empty-state
Collaborator
zachseidner1
left a comment
zachseidner1
left a comment
There was a problem hiding this comment.
Pretty clean for the most part, nice job! Thank you Amy. There's a couple minor things I'd like you to fix.
app/src/main/java/com/cornellappdev/score/components/EmptyState.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/components/EmptyState.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/score/screen/PastGamesScreen.kt
Outdated
Show resolved
Hide resolved
Closed
zachseidner1
approved these changes
Apr 21, 2025
Collaborator
zachseidner1
left a comment
zachseidner1
left a comment
There was a problem hiding this comment.
Very nice work! Left a few nits but feel free to just merge if you want lol
Comment on lines
177
to
178
| } | ||
| if (uiState.filteredGames.isEmpty()) { |
Collaborator
There was a problem hiding this comment.
nit: better to use else here?
Comment on lines
213
to
217
| Column( | ||
| modifier = Modifier | ||
| .fillMaxSize() | ||
| .background(color = Color.White) | ||
| ) { |
Collaborator
There was a problem hiding this comment.
Nit: I can remove this column and the preview still works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Address issue #34
Changes Made
Added EmptyState component, implemented appropriately in PastGamesScreen and HomeScreen
Test Coverage
Visually correct