-
Notifications
You must be signed in to change notification settings - Fork 0
HomeViewModel/ScoreRepositoryRefactor #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 20 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
6b64bcb
Date functions refactor
amjiao 794d74d
Add Result.kt
amjiao d131253
functioning refactored HomeViewModel
amjiao f747104
Reformat code
amjiao 87bd8ac
Gradle + Library updates
amjiao 6759922
Having RootNavigation Hilt/injection issues?
amjiao daff2de
Added Result checks to ScoreRepository
amjiao e01764d
Updated to display all games in LazyColumn and first 3 games in upcom…
amjiao 2a0b5d3
Merge branch 'main' into Amy/games-model
amjiao 66fbd80
small fixes
amjiao a46ddfb
PR fixes checkpoint
amjiao e1ce60c
HomeContent abstraction
amjiao cd2e9ee
Temp update
amjiao 8b6c36a
Date fixes
amjiao ae435ea
Refactored HomeViewModel with map and toGameCardData
amjiao d245b66
Cleanup
amjiao 67de87d
Merge branch 'main' into Amy/games-model
amjiao 5261c04
Documentation + cleanup
amjiao db7ed2d
Merge branch 'Amy/games-model' of https://github.com/cuappdev/score-a…
amjiao b15ede0
formatColor relocation
amjiao d18f9ae
Revisions
amjiao d5590e0
Revert agp version
amjiao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| package com.cornellappdev.score.model | ||
|
|
||
| import com.apollographql.apollo.api.ApolloResponse | ||
| import com.apollographql.apollo.api.Operation | ||
| import com.apollographql.apollo.exception.NoDataException | ||
|
|
||
| /** | ||
| * Maps an ApolloResponse to a generic Kotlin result. It either provides the data with no errors, or | ||
| * a failure response containing the error message in the throwable. | ||
| */ | ||
| fun <T : Operation.Data> ApolloResponse<T>.toResult(): Result<T> { | ||
| if (hasErrors() || exception != null) { | ||
| return Result.failure( | ||
| exception?.cause ?: RuntimeException( | ||
| errors?.firstOrNull()?.message ?: "Unknown error occurred" | ||
| ) | ||
| ) | ||
| } | ||
| return try { | ||
| Result.success(dataOrThrow()) | ||
| } catch (e: NoDataException) { | ||
| Result.failure(e) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.