Feedback - #1
Conversation
| * The Clawpack community was most active approximately 5-10 years ago and is less active these days. It may not be the best choice going forward for a project. | ||
|
|
||
| * PyClaw has the most contributors and lots of documentaiton (would be the best solver of the four to choose for a project). | ||
| * GeoClaw had the most changes in the past year, but only one contributor. | ||
| * Submitted request to join Clawpack Slack channel but have yet to hear back from them. |
There was a problem hiding this comment.
I bumped one of the developers about their Slack.
I would regard Clawpack as being essentially one project that has chosen to organize into different repositories. The top-level clawpack/clawpack has the others as submodules. So commits may be scattered around, but it operates almost the same as if everything had been merged into a mono-repo.
This is a related package you might find interesting. https://github.com/geoflows/D-Claw
| * For PyClaw, 46 of 48 tests in the test suite pass and two tests fail. The two tests failed with the error "no such file or directory" for the verification file (the file name for the verificaiton file might be mislabeld for those tests). | ||
| * For the calssic solver, all three tests in the test suite failed. |
There was a problem hiding this comment.
Hmm, it looks like continuous integration isn't running any more and I see an issue about Travis (which doesn't provide free minutes to open source any more).
https://app.travis-ci.com/github/clawpack/clawpack/builds
| * Permissive license: Berkeley Software Distribution (BSD) license (BSD 3-Clause) | ||
| * Concern about license: On the Clawpack website the copyright is from 1994-2020, does that mean it is no longer in effect? | ||
| * "Copyright (c) 1994–2020, The Clawpack Development Team. All rights reserved." |
There was a problem hiding this comment.
Copyright exists whether you write that line or not, for every year you develop it, also whether or not it's written. I personally dislike including the year because it leads to this sort of confusion. Some projects use automation to update the copyright notice on every file each year (but that's technically incorrect if the file hasn't been modified). The fact that copyright nominally has a finite duration seems moot when Congress keeps extending the expiration to appease Disney, which lobbies to protect its characters from entering the public domain.
2 participants
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mainsince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.main. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @Mateus-A-R-Braga