feat: implement migrating upper container layer #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a very basic implementation of migrating the containers ephemeral storage during migration. It only supports the overlay snapshotter. It simply finds the upper layer by looking at /proc/*/mounts and then renames all paths in the upper layer into the snapshot directory before evac. On restore we do the reverse. This works okay for a first iteration but there may be many edge-cases and potential performance improvements. Especially the image pulling over TTRPC could be improved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very basic implementation of migrating the containers ephemeral storage during migration. It only supports the overlay snapshotter. It simply finds the upper layer by looking at /proc/*/mounts and then renames all paths in the upper layer into the snapshot directory before evac. On restore we do the reverse. This works okay for a first iteration but there may be many edge-cases and potential performance improvements. Especially the image pulling over TTRPC could be improved.