Adds new option to limit the length of the generated slugs. #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a new feature that limits the length of generated slugs by incorporating a MaximumLength option in the configuration.
- Introduces a MaximumLength property to SlugHelperConfiguration.
- Adds logic in GenerateSlug to trim the slug to the MaximumLength with a check to remove a trailing dash.
- Provides new test cases in SlugHelperTests to validate this behavior.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/Slugify.Core.Tests/SlugHelperTests.cs | Added tests to verify the MaximumLength functionality |
| src/Slugify.Core/SlugHelper.cs | Updated the GenerateSlug method to enforce MaximumLength and remove trailing dashes |
| src/Slugify.Core/SlugHelperConfiguration.cs | Introduced the new MaximumLength property to the configuration |
Co-authored-by: Copilot <[email protected]>
…to length-limit
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-implementation of #50 against the V5 codebase.
Tests have been copypasta'd
Fixes #18