Make DESCRIPTION_SOURCE into a class var too. I can see I'm going to …

…be doing this a lot.
ctkcoding · Feb 13, 2021 · a306a3e · a306a3e
1 parent 2ad4f2a
commit a306a3e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/dir2cast.php b/dir2cast.php
@@ -745,6 +745,7 @@ public function getImage()
 class Media_RSS_Item extends RSS_File_Item implements Serializable {
 
     static $LONG_TITLES = false;
+    static $DESCRIPTION_SOURCE = 'comment';
 
     public function __construct($filename)
     {
@@ -810,7 +811,7 @@ public function getDescription()
 
         // The default value is "comment". dir2cast prior to v1.19
         // used value "file", so it's here for backward compatibility
-        if(DESCRIPTION_SOURCE == 'summary' || DESCRIPTION_SOURCE == 'file')
+        if(self::$DESCRIPTION_SOURCE == 'summary' || self::$DESCRIPTION_SOURCE == 'file')
             return parent::getSummary(); // call to parent because otherwise we could co-recurse.
 
         return $this->getID3Comment();
@@ -1811,6 +1812,7 @@ public function init()
             $itunes = $podcast->addHelper(new iTunes_Podcast_Helper());
 
             Media_RSS_Item::$LONG_TITLES = LONG_TITLES;
+            Media_RSS_Item::$DESCRIPTION_SOURCE = DESCRIPTION_SOURCE;
 
             $podcast->setTitle(TITLE);
             $podcast->setLink(LINK);

diff --git a/test/Media_RSS_ItemTest.php b/test/Media_RSS_ItemTest.php
@@ -10,7 +10,7 @@ public static function setUpBeforeClass(): void
     {
         RSS_File_ItemTest::setUpBeforeClass();
         Media_RSS_Item::$LONG_TITLES = false;
-        defined('DESCRIPTION_SOURCE') || define('DESCRIPTION_SOURCE', 'comment');
+        Media_RSS_Item::$DESCRIPTION_SOURCE = 'comment';
     }
 
     public function getMediaFileContent()