Skip to content

Commit

Permalink
Add note about how I'm using serialization wrong.
Browse files Browse the repository at this point in the history
  • Loading branch information
ben-xo committed Feb 14, 2021
1 parent f358eb4 commit 2be4a8e
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions test/Media_RSS_Item_SerializationTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ public function test_unserialize_rejects_invalid_serialization_version()
$item2 = unserialize($serialized);
}

/**
* TODO: I am using serialize/unserialize wrong here. I should unset these properties on load, not save.
* But that would require a version bump in the cache constant.
*/
public function test_unserialize_does_not_overwrite_properties_set_from_fs_metadata()
{
$item = new Media_RSS_Item('example.mp3');
Expand Down

0 comments on commit 2be4a8e

Please sign in to comment.