Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait until the longterm datacheck file is created to make the link #279

Merged
merged 7 commits into from
Feb 26, 2024

Conversation

marialainez
Copy link
Collaborator

@marialainez marialainez commented Feb 21, 2024

Currently, autocloser is trying to make the symlink of the file right after the cherenkov_transparency script is launched, and it fails because the file has not yet been created. I put long times to wait for the job completion because nowadays there are many jobs running in the cluster, and many of them stay in PENDING status for a long time until they start running.

EDIT:

The first time closer runs it will go through the else, and wait to see if all the jobs are finished (until the hour), if so, the flag is created. If it is not closed after that hour, there is no nightfinished flag. Then closer runs again, first it checks that the longterm file exists, if it does it goes to the job completion check directly and tries to close again.

src/osa/paths.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 63.82979% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 81.77%. Comparing base (5eb79d5) to head (2d6a529).

Files Patch % Lines
src/osa/paths.py 55.17% 13 Missing ⚠️
src/osa/scripts/closer.py 77.77% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
- Coverage   82.06%   81.77%   -0.30%     
==========================================
  Files          57       57              
  Lines        4885     4911      +26     
==========================================
+ Hits         4009     4016       +7     
- Misses        876      895      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/osa/paths.py Outdated Show resolved Hide resolved
src/osa/paths.py Outdated Show resolved Hide resolved
src/osa/scripts/closer.py Show resolved Hide resolved
@morcuended morcuended merged commit 100685b into main Feb 26, 2024
5 of 7 checks passed
@morcuended morcuended deleted the link_datacheck branch February 26, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants