Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use first event time in update catalog script #264

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Use first event time in update catalog script #264

merged 2 commits into from
Jan 11, 2024

Conversation

morcuended
Copy link
Member

@morcuended morcuended commented Dec 13, 2023

Also some cleanup is done.

Closes #262

Copy link
Collaborator

@marialainez marialainez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the format and scale of the dragon_time the same as that of the times in the run_start column?

@morcuended
Copy link
Member Author

Isn't the format and scale of the dragon_time the same as that of the times in the run_start column?

good point, I would have to check again

@morcuended
Copy link
Member Author

Isn't the format and scale of the dragon_time the same as that of the times in the run_start column?
No, run_start in the summary was defined like

run_start = int(round(Time(f.camera_config.date, format="unix").unix_tai)) * int(1e9)

The proper way of getting the eventwise timestamps from dragon_time is using time = (timestamp, format="unix", scale="utc"). Then, getting the ISO format in UTC scale as time.utc.iso (to make sure to use UTC scale). So I think it is fine as it is now

@morcuended
Copy link
Member Author

To make the tests pass you need to merge the current main version to force the usage of lstchain >=v0.10.5

@morcuended morcuended merged commit 053481f into main Jan 11, 2024
2 of 5 checks passed
@morcuended morcuended deleted the run_start branch January 11, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review Please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong run_start values in source catalog for runs taken with EVBv6
2 participants